Skip to content

okkkoo#3

Open
maejoux wants to merge 2 commits intomasterfrom
my-slide
Open

okkkoo#3
maejoux wants to merge 2 commits intomasterfrom
my-slide

Conversation

@maejoux
Copy link
Owner

@maejoux maejoux commented Aug 20, 2019

gjg

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 7: Respond to a review

Your pull request is looking great!

Let’s add some content to your file. Replace line 5 of your file with a quotation or meme and witty caption. Remember: Markdown is supported.

⌨️ Activity: Change your file

  1. Check out to your branch:
    git checkout my-slide
  2. Open the file _posts/0000-01-02-maejoux.md.
  3. Replace line 5 of the file with something new.
  4. Stage your new changes:
    git add _posts/0000-01-02-maejoux.md
  5. Commit your changes:
    git commit -m "<YOUR-MESSAGE>"
  6. Push your edits to GitHub:
    git push

I'll respond when I detect a commit on this branch.

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 8: Merge your pull request

Nicely done @maejoux! ✨

You successfully created a pull request, and it has passed all of the tests. You can now merge your pull request.

⌨️ Activity: Merge the pull request

  1. Check out to the master branch:

    git checkout master
  2. Merge your branch:

    git merge my-slide
  3. Push the merged history to GitHub:

    git push
  4. Delete your the branch locally:

    git branch -d my-slide
  5. Once your branch has been merged, you don't need it anymore. Click Delete branch.


I'll respond when this pull request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant